Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade Circle to XCode 9.3.1 #2406

Closed
wants to merge 8 commits into from
Closed

WIP: Upgrade Circle to XCode 9.3.1 #2406

wants to merge 8 commits into from

Conversation

aksonov
Copy link
Contributor

@aksonov aksonov commented May 29, 2018

In order to make sure that our app works under xcode 9.3 we must use xcode 9.3 for our tests

@southerneer any ideas how to fix mocks?

@southerneer
Copy link
Contributor

Why does the bump to XCode 9.3.1 affect our jest tests? That doesn't make any sense. Does the CircleCI image use a different version of node maybe? I think we should figure out how the change affected the environment before we start fixing things.

@aksonov
Copy link
Contributor Author

aksonov commented May 29, 2018 via email

@southerneer
Copy link
Contributor

Jest is newer? None of your commits update jest.

@southerneer
Copy link
Contributor

I bet the CircleCI image uses Node 10 and causes this: jestjs/jest#2567 (comment)

Testing that theory now

@southerneer
Copy link
Contributor

Yep, that's gotta be it. Here are the specs for the CircleCI XCode 9.3.1 image: https://circle-macos-docs.s3.amazonaws.com/image-manifest/build-419/index.html

@southerneer
Copy link
Contributor

OK, I was able to repro the errors locally by installing Node 10.1.0 (to match CircleCI) and running yarn jest --no-cache.

The fix is to pull in the latest betas of jest: jestjs/jest#6075 (comment)

@southerneer
Copy link
Contributor

southerneer commented May 29, 2018 •
edited
Loading

Now seeing socket-related errors...probably also related to the node version upgrade. Since we're evaluating appcenter builds as CI this point may be moot.

Uncaught RangeError [ERR_OUT_OF_RANGE]: The value of "value" is out of range. It must be >= 0 and <= 4294967295. Received -301418281
      at checkInt (internal/buffer.js:35:11)
      at writeU_Int32BE (internal/buffer.js:625:3)
      at Buffer.writeUInt32BE (internal/buffer.js:638:10)
      at WebSocketFrame.toBuffer (node_modules/websocket/lib/WebSocketFrame.js:257:24)
      at WebSocketConnection.sendFrame (node_modules/websocket/lib/WebSocketConnection.js:852:43)
      at WebSocketConnection.fragmentAndSend (node_modules/websocket/lib/WebSocketConnection.js:788:14)
      at WebSocketConnection.sendUTF (node_modules/websocket/lib/WebSocketConnection.js:728:10)
      at W3CWebSocket.send (node_modules/websocket/lib/W3CWebSocket.js:116:26)
      at Strophe.Websocket._onOpen (node_modules/strophejs/strophe.js:5587:21)
      at W3CWebSocket._dispatchEvent [as dispatchEvent] (node_modules/yaeti/lib/EventTarget.js:107:17)
      at W3CWebSocket.onConnect (node_modules/websocket/lib/W3CWebSocket.js:208:10)
      at WebSocketClient.<anonymous> (node_modules/websocket/lib/W3CWebSocket.js:55:19)
      at WebSocketClient.succeedHandshake (node_modules/websocket/lib/WebSocketClient.js:335:10)
      at WebSocketClient.validateHandshake (node_modules/websocket/lib/WebSocketClient.js:319:10)
      at ClientRequest.handleRequestUpgrade (node_modules/websocket/lib/WebSocketClient.js:248:14)
      at Socket.socketOnData (_http_client.js:457:11)
      at addChunk (_stream_readable.js:277:12)
      at readableAddChunk (_stream_readable.js:262:11)
      at Socket.Readable.push (_stream_readable.js:217:10)
      at TCP.onread (net.js:638:20)

@southerneer
Copy link
Contributor

Since we're using AppCenter for macOS-based tests this PR no longer applies. Please don't delete the branch, though, until we've finished evaluating AppCenter builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aksonov @southerneer